Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: create tabular-data.ipynb #330

Merged
merged 8 commits into from
Jun 14, 2021

Conversation

raybellwaves
Copy link
Member

@raybellwaves raybellwaves commented Jun 13, 2021

Added a tabular-data.ipynb notebook to show how you can use xskillscore in regression problems with tabular (pandas.DataFrame) data

Related to #217

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #330 (86e9c4d) into main (60f974c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          23       23           
  Lines        2627     2627           
=======================================
  Hits         2483     2483           
  Misses        144      144           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7be06...86e9c4d. Read the comment docs.

Copy link
Collaborator

@aaronspring aaronspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check whether the performance increase depends on the order of computation? Could you check once the pd version after the xr version?

@raybellwaves
Copy link
Member Author

Could you check whether the performance increase depends on the order of computation? Could you check once the pd version after the xr version?

Screen Shot 2021-06-13 at 9 50 54 PM

@raybellwaves raybellwaves merged commit 2919931 into xarray-contrib:main Jun 14, 2021
@raybellwaves raybellwaves deleted the tabular-nb branch June 14, 2021 02:48
@aaronspring
Copy link
Collaborator

I didn't mean that. I meant rerunning the pd cell after the xs cell to check if performance increase comes from data in memory already. Probably not the case @raybellwaves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants