Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass kwargs and assume_sorted to xarray interp for both DataArray and Dataset #270

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Pass kwargs and assume_sorted to xarray interp for both DataArray and Dataset #270

merged 4 commits into from
Jul 28, 2024

Conversation

martijnvandermarel
Copy link
Contributor

@martijnvandermarel martijnvandermarel commented Jul 10, 2024 •
edited
Loading

@martijnvandermarel
Copy link
Contributor Author

@keewis Please let me know if tests and whats-new changes are needed for this PR.

@keewis
Copy link
Collaborator

keewis commented Jul 16, 2024

sorry for the late reply, and thanks for the PR!

Yes, tests would be great so we don't regress. That can be very simple ones like comparing the results of .pint.interp and .interp if no unit conversion is necessary.

whats-new changes

yes, please.

keewis
keewis reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, just a few comments on the tests

pint_xarray/tests/test_accessors.py Outdated Show resolved Hide resolved
pint_xarray/tests/test_accessors.py Outdated Show resolved Hide resolved
pint_xarray/tests/test_accessors.py Outdated Show resolved Hide resolved
martijnvandermarel and others added 2 commits July 22, 2024 10:22
@martijnvandermarel @keewis
Explicit dict for quantify
d2adec6 
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
@martijnvandermarel
move kwargs test to separate parameter set
4481014
@martijnvandermarel
Copy link
Contributor Author

Thanks @keewis , I adapted the tests based on your comments.

@keewis
Copy link
Collaborator

keewis commented Jul 28, 2024

once again sorry for being somewhat slow. Looks good to me now!

@keewis keewis merged commit d3e9585 into xarray-contrib:main Jul 28, 2024
16 checks passed
@martijnvandermarel martijnvandermarel deleted the fix-passing-interp-kwargs branch August 5, 2024 11:03
@martijnvandermarel
Copy link
Contributor Author

No problem! @keewis any chance this gets released soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijnvandermarel @keewis