-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass kwargs
and assume_sorted
to xarray interp
for both DataArray
and Dataset
#270
Pass kwargs
and assume_sorted
to xarray interp
for both DataArray
and Dataset
#270
Conversation
@keewis Please let me know if tests and |
sorry for the late reply, and thanks for the PR! Yes, tests would be great so we don't regress. That can be very simple ones like comparing the results of
yes, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, just a few comments on the tests
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
Thanks @keewis , I adapted the tests based on your comments. |
once again sorry for being somewhat slow. Looks good to me now! |
No problem! @keewis any chance this gets released soon? |
interp
kwargs toDataArray.interp
#267pre-commit run --all-files
whats-new.rst