[Xamarin.Android.Build.Tasks] JarToXml & BindingsGenerator l10n support #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzagaeski
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Apr 20, 2020
Add codes for the existing errors in `<JarToXml/>` and `<BindingsGenerator/>`, and move the message strings into the `.resx` file so that they are localizable. Other changes: Adjust the wording of the messages to standardize some terms, capitalizations, and punctuation. Remove the `subcategory` parameters from the `LogError()` calls in `<BindingsGenerator/>` because no other errors in Xamarin.Android use the `subcategory` parameter of `LogError()`.
jonpryor
pushed a commit
that referenced
this pull request
Apr 23, 2020
…rt (#4579) Context: 0342fe5 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Add codes for the existing errors in `<JarToXml/>` and `<BindingsGenerator/>`, and move the message strings into the `.resx` file so that they are localizable. Other changes: Adjust the wording of the messages to standardize some terms, capitalizations, and punctuation. Remove the `subcategory` parameters from the `LogError()` calls in `<BindingsGenerator/>` because no other errors in Xamarin.Android use the `subcategory` parameter of `LogError()`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add codes for the existing errors in
<JarToXml/>and<BindingsGenerator/>, and move the message strings into the.resxfile so that they are localizable.
Other changes:
Adjust the wording of the messages to standardize some terms,
capitalizations, and punctuation.
Remove the
subcategoryparameters from theLogError()calls in<BindingsGenerator/>because no other errors in Xamarin.Android usethe
subcategoryparameter ofLogError().