[linker] use Java.Interop's TypeDefinitionCache #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/java-interop@b81cfbb Similar to aff3b52, we can use `TypeDefinitionCache` in a few places in the linker. My approach was to make each linker step require a `TypeDefinitionCache` for its constructor as needed. This made a single `TypeDefinitionCache` used throughout a linker `Pipeline`. The `<LinkAssembliesNoShrink/>` MSBuild task could also control the lifetime of the `TypeDefinitionCache`. The results of building the Xamarin.Forms integration project on Windows: Before: 706 ms LinkAssembliesNoShrink 1 calls After: 695 ms LinkAssembliesNoShrink 1 calls On macOS / mono: Before: 1248 ms LinkAssembliesNoShrink 1 calls After: 1228 ms LinkAssembliesNoShrink 1 calls This saves ~20ms for a small app, but is probably worth it to get rid of the `[Obsolete]` warnings caused by: https://github.com/xamarin/java.interop/blob/4f47ec82c14ae6ca23c1dcde3f7b5c8b93b6a4f7/src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/TypeDefinitionRocks.cs#L70-L72
dellis1972
approved these changes
Feb 25, 2020
jonpryor
pushed a commit
that referenced
this pull request
Feb 26, 2020
Context: dotnet/java-interop@b81cfbb Similar to aff3b52, we can use `TypeDefinitionCache` in a few places in the linker. My approach was to make each linker step require a `TypeDefinitionCache` for its constructor as needed. This made a single `TypeDefinitionCache` used throughout a linker `Pipeline`. The `<LinkAssembliesNoShrink/>` MSBuild task could also control the lifetime of the `TypeDefinitionCache`. The results of building the Xamarin.Forms integration project on Windows: Before: 706 ms LinkAssembliesNoShrink 1 calls After: 695 ms LinkAssembliesNoShrink 1 calls On macOS / mono: Before: 1248 ms LinkAssembliesNoShrink 1 calls After: 1228 ms LinkAssembliesNoShrink 1 calls This saves ~20ms for a small app, but is probably worth it to get rid of the `[Obsolete]` warnings caused by: https://github.com/xamarin/java.interop/blob/4f47ec82c14ae6ca23c1dcde3f7b5c8b93b6a4f7/src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/TypeDefinitionRocks.cs#L70-L72
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop@b81cfbb
Similar to aff3b52, we can use
TypeDefinitionCachein a few placesin the linker. My approach was to make each linker step require a
TypeDefinitionCachefor its constructor as needed. This made asingle
TypeDefinitionCacheused throughout a linkerPipeline. The<LinkAssembliesNoShrink/>MSBuild task could also control thelifetime of the
TypeDefinitionCache.The results of building the Xamarin.Forms integration project on
Windows:
On macOS / mono:
This saves ~20ms for a small app, but is probably worth it to get rid
of the
[Obsolete]warnings caused by:https://github.com/xamarin/java.interop/blob/4f47ec82c14ae6ca23c1dcde3f7b5c8b93b6a4f7/src/Java.Interop.Tools.Cecil/Java.Interop.Tools.Cecil/TypeDefinitionRocks.cs#L70-L72