Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] Fix the Shell story when running on iPad in multi task mode #8527

Closed
PureWeen opened this issue Nov 15, 2019 · 1 comment · Fixed by #12097
Closed

[Bug] Fix the Shell story when running on iPad in multi task mode #8527

PureWeen opened this issue Nov 15, 2019 · 1 comment · Fixed by #12097
Labels
a/shell 🐚 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested p/iOS 🍎 p/tablet t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Milestone

Comments

@PureWeen
Copy link
Contributor

Description

Very similar to the issue here
#2017 (comment)

Along with this fix it'd be nice to expose a platform specific out so the user can be aware that an app has transitioned to "Collapsed mode" And then make decisions about layouts.

If you compare the Apple News app vs the Notes app you'll see each one handles split view differently.

Apple News transitioned out of split view and only lets you see the DetailsViewController and then the Notes app transitions to a UINavigationController experience where the master is at the root of your stack.

My thinking is that the Notes app should be the default but we should expose something out to let the user change to a different shell layout if they need to

Steps to Reproduce

Run Control Gallery
switched to store shell

  1. Move to 30 percent shell / 70 percent other
  2. click something in menu that navigates
  3. crashes

Expected Behavior

It should navigate away from the Master ViewController to the details controller you clicked on. Compare the behavior to the Notes app.

Actual Behavior

Currently it just crashes

@PureWeen PureWeen added t/bug 🐛 s/unverified New report that has yet to be verified a/shell 🐚 and removed s/unverified New report that has yet to be verified labels Nov 15, 2019
@PureWeen PureWeen added this to the 4.4.0 milestone Nov 15, 2019
@hartez hartez changed the title [Bug] Fix the Shell storing when running on iPad in multi task mode [Bug] Fix the Shell story when running on iPad in multi task mode Nov 15, 2019
@samhouts samhouts modified the milestones: 4.4.0, 4.5.0 Nov 20, 2019
@Jared-Aus
Copy link

My issue matches the title, but not necessarily the description. The simplest way to demonstrate that Shell is broken with iPad split screen is to create two new XF solutions in VS, one using the shell template and the other with the blank template. At a 50/50 split the blank template shows content and the shell template a white screen. It makes no difference if using XF 4.2, 4.3, or 4.4.0-pre2.

@samhouts samhouts removed this from the 4.5.0 milestone Jan 9, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Jul 17, 2020
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! and removed inactive Issue is older than 6 months and needs to be retested labels Jul 31, 2020
@samhouts samhouts added this to the 5.0.0 milestone Aug 13, 2020
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Sep 11, 2020
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shell 🐚 help wanted We welcome community contributions to any issue, but these might be a good place to start! in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested p/iOS 🍎 p/tablet t/bug 🐛 up-for-grabs We welcome community contributions to any issue, but these might be a good place to start!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants