[Enhancement] Allow everyone access to the WeakEventManager class

[rwaldenfraedom]

Summary

I would like to use the WeakEventManager so that my event registrations don't hold on to object when they should have been removed.

API Changes

change the class viability modifier from internal to public on the class Xamarin.Forms.WeakEventManager

e.g.

internal class Xamarin.Forms.WeakEventManager

to

public class Xamarin.Forms.WeakEventManager

Intended Use Case

Allow object to be disposed if the only thing that still references then are event registrations

[brminnick]

@rwaldenfraedom I’ve implemented WeakEventManager in this library: https://github.com/brminnick/AsyncAwaitBestPractices#weakeventmanager

It is available in NuGet here: https://www.nuget.org/packages/AsyncAwaitBestPractices/

This was inspired by Xamarin.Forms’ WeakEventManager, and I’ve expanded on it, adding support for event Action, event Action<T>, and event Delegate.

[rwaldenfraedom]

Thanks @brminnick for letting me know of your NuGet. At my company all third party libraries need to be reviewed and approved before been used. Having it as part of Xamarin would be preferable.

[brminnick]

@rwaldenfraedom The code is all open source and you’re welcome to copy/paste my implementation into your code base.

[Insire]

Any news on this? I'd like to rely on the official implementation, instead of copying pasting the code over.

[rwaldenfraedom]

YAY thanks @samhouts @StephaneDelcroix