Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Spec] Shell Flyout Footer Template #6292

Closed
davidortinau opened this issue May 24, 2019 · 6 comments · Fixed by #6432
Closed

[Spec] Shell Flyout Footer Template #6292

davidortinau opened this issue May 24, 2019 · 6 comments · Fixed by #6432

Comments

@davidortinau
Copy link
Contributor

davidortinau commented May 24, 2019

Flyout Footer Template

Add a template for the footer of the flyout menu just like you have for the header.

  • The footer should be fixed to the bottom of the flyout.
  • The menu list should not go behind it and obscure the menu items.
  • The footer should take any height.
<Shell.FlyoutFooterTemplate>
    <DataTemplate>
        <Grid>ContentHere</Grid>
    </DataTemplate>
</Shell.FlyoutFooterTemplate>

API

Shell.FlyoutFooterTemplate takes a DataTemplate

Difficulty : Low

@SkyeHoefling
Copy link
Contributor

SkyeHoefling commented Jun 5, 2019

I started an implementation of this for Andoird and I was able to get it working. I need to add unit tests and do some more testing.

Should I submit the PR with just the android implementation or would it be better to submit it with both iOS and Android?

image

@PureWeen
Copy link
Contributor

PureWeen commented Jun 5, 2019

Yea! Submit a PR if you can

I have a PR over here
#6383

where I'm working on some changes with the flyout measurements so we'll need to reconcile the two. But either way submit away!!!

@SkyeHoefling
Copy link
Contributor

Perfect! I'll submit the PR tomorrow morning.

It took me most of the night to get the bugs worked out with it but I have it working. I was running into a problem where the RecyclerView kept rendering behind the footer (red) and I wasn't able to adjust the margin. I ended up calculating the footer height and setting it in the renderer and it all started working.

Here is a sneak peak with it working with many FlyoutItems

shell_footer_demo

@samhouts samhouts modified the milestones: 4.3.0, 4.4.0 Aug 29, 2019
@samhouts samhouts modified the milestones: 4.4.0, 4.5.0 Nov 20, 2019
@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 24, 2019
@samhouts samhouts added inactive Issue is older than 6 months and needs to be retested help wanted We welcome community contributions to any issue, but these might be a good place to start! labels Dec 3, 2019
@samhouts samhouts added the up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! label Dec 3, 2019
@samhouts samhouts removed help wanted We welcome community contributions to any issue, but these might be a good place to start! up-for-grabs We welcome community contributions to any issue, but these might be a good place to start! labels Feb 4, 2020
@samhouts samhouts removed this from the 4.5.0 milestone Feb 11, 2020
@samhouts samhouts removed in-progress This issue has an associated pull request that may resolve it! inactive Issue is older than 6 months and needs to be retested labels Apr 15, 2020
@fakhravari
Copy link

When it is released

@douglassimaodev
Copy link

We are in XF 4.8.. next month will go to 5.0 and yet we don't have Shell.FlyoutFooter>.... any idea when/if it will be available?

@VladislavAntonyuk
Copy link
Contributor

It is already available in nightly builds. So should be available in 5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants