The ClearButton is no longer displayed in the entry

[MartinScha]

Description

If I'm using version 4.8.0.1364, the ClearButton is displayed in the entry.
When using version 4.8.0.1451 and higher, the ClearButton is no longer displayed.

Steps to Reproduce

1. Place an entry on a page in a new or existing app with Xamarin.Forms version 4.8.0.1364.
2. Set the ClearButtonVisibility property to ClearButtonVisibility.WhileEditing
3. Start the UWP app. The ClearButton is displayed.
4. Update the Xamarin.Forms version to version 4.8.0.1451 or higher.
5. Start the UWP app again. The ClearButton is not displayed.

Expected Behavior

ClearButton is displayed in the entry.

Actual Behavior

ClearButton is not displayed in the current version of Xamarin.Forms.

Basic Information

• Version with issue: Version 4.8.0.1451 and higher
• Last known good version: Version 4.8.0.1364
• IDE: Visual Studio 2019
• Platform Target Frameworks:
  • iOS: Is not used
  • Android: Not used yet
  • UWP: 18362
• Android Support Library Version:
• Nuget Packages: Microsoft.NetCore.UniversalWindowsPlatform, Xamarin Essentials, Xamarin.Forms
• Affected Devices: Windows 10 Desktop (Windows 10 Pro, Version 10.0.19041, Build 19041)

Screenshots

Reproduction Link

[bmacombe]

It looks like to me that the Entry default behavior in XF is to never show the clear button.

		public static readonly BindableProperty ClearButtonVisibilityProperty = BindableProperty.Create(nameof(ClearButtonVisibility), typeof(ClearButtonVisibility), typeof(Entry), ClearButtonVisibility.Never);

I suspect before #9250 and #11953 the UWP Entry Renderer never set the clear button visibility, so it was honoring the UWP default of show vs the XF default of hiding it.

I'd vote we honor the XF behavior to be consistent with the other platforms.

@MartinScha You can set the visibility to always with platform specifics if you want the pre 4.8.0.1451 behavior.

[bmacombe]

Hey misread the description, I do see the problem, working on a PR now.

[bmacombe]

Fixed the issue and updated to the 8836 issue page to display a pre load set of Never and WhileEdting along with a toggle to test changing after load.