Android textAllCaps no longer works

[atexinspect]

Description

Android textAllCaps no longer works when using XF 4.8.0.1269

Steps to Reproduce

1. Install XF 4.8.0.1269
2. Run Android App
3. Button text is always in capitals

Expected Behavior

Button text should be camel case

Actual Behavior

Button text always capitals

Basic Information

• Version with issue:
• Last known good version: XF 4.7.0.1260
• IDE: VS 2019 V16.7.0
• Platform Target Frameworks:
  • Android:

[rmarinho]

@atexinspect text on android was always all caps no? do you have an example we can look?!

Thanks

[atexinspect]

In styles.xml

<?xml version="1.0" encoding="utf-8" ?>
<resources>
  <style name="Theme.Splash"
        parent="android:Theme">
    <item name="android:windowBackground">@drawable/splashscreen</item>
    <item name="android:windowNoTitle">true</item>
  </style>
  <style name="MainTheme" parent="MainTheme.Base">
  </style>
  <!-- Base theme applied no matter what API -->
  <style name="MainTheme.Base" parent="Theme.AppCompat.Light.DarkActionBar">
    <!--If you are using revision 22.1 please use just windowNoTitle. Without android:-->
    <item name="windowNoTitle">true</item>
    <!--We will be using the toolbar so no need to show ActionBar-->
    <item name="windowActionBar">false</item>
    <!-- Set theme colors from http://www.google.com/design/spec/style/color.html#color-color-palette -->
    <!-- colorPrimary is used for the default action bar background -->
    <item name="colorPrimary">#2196F3</item>
    <!-- colorPrimaryDark is used for the status bar -->
    <item name="colorPrimaryDark">#1976D2</item>
    <!-- colorAccent is used as the default value for colorControlActivated
         which is used to tint widgets -->
    <item name="colorAccent">#96BCE3</item>
    <!-- You can also set colorControlNormal, colorControlActivated
         colorControlHighlight and colorSwitchThumbNormal. -->
    <item name="windowActionModeOverlay">true</item>
    <item name="android:datePickerDialogTheme">@style/AppCompatDialogStyle</item> 
    <item name="android:colorPressedHighlight">@color/ListViewSelected</item>
    <item name="android:colorLongPressedHighlight">@color/ListViewHighlighted</item>
    <item name="android:colorFocusedHighlight">@color/ListViewSelected</item>
    <item name="android:colorActivatedHighlight">@color/ListViewSelected</item>
    <item name="android:activatedBackgroundIndicator">@color/ListViewSelected</item>

    <item name="android:textAllCaps">false</item>  <!-- Does not work with XF 4.8.0.1269 / Works with XF 4.7.0.1260 -->

    <!-- In Tabbar.axml app:tabTextAppearance="@android:style/TextAppearance.Widget.TabWidget" makes tab page text camel case --> 
    
  </style>   
  <style name="AppCompatDialogStyle" parent="Theme.AppCompat.Light.Dialog">
    <item name="colorAccent">#96BCE3</item>
  </style>
</resources>

Tabbar.xml

<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.TabLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:id="@+id/sliding_tabs"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:background="?attr/colorPrimary"
    app:tabTextAppearance="@android:style/TextAppearance.Widget.TabWidget"
    android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"
    app:tabIndicatorColor="@android:color/white"
    app:tabGravity="fill"
    app:tabMode="fixed" /

Tabbar.xml still gives correct camel case on tabs with XF 4.7.0.1260 & XF 4.8.0.1269

Regards
Paul.

[rmarinho]

@atexinspect can you upload a small repro?! Thanks

[atexinspect]

https://github.com/atexinspect/CapsTest

[Pantheas]

Creating a custom button renderer and calling SetAllCaps(false); does not work aswell...

[Pantheas]

@atexinspect setting TextTransform="None" in global Button style worked for me...

[atexinspect]

@atexinspect setting TextTransform="None" in global Button style worked for me...

Worked for me too. Thanks.

[manikandantk88]

@atexinspect Thanks for the solution. Worked.

[kevcrooks]

We'd previously fixed the issue using the workaround mentioned above too.

We tried removing it just now on Xamarin.Forms version 4.8.0.1687, and the capitalisation issue seems to have been fixed for us. I haven't checked which version this seems to have been fixed from though.

[Cfun1]

@samhouts isn't a duplicate of #11556 ?

[rmarinho]

This should be fixed by #12170