Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to handle constants? #10

Open
chrisdrackett opened this issue Jun 12, 2019 · 0 comments
Open

how to handle constants? #10

chrisdrackett opened this issue Jun 12, 2019 · 0 comments

Comments

@chrisdrackett
Copy link
Contributor

I'm currently migrating my react mapkit library to typescript from flow and I'm trying to use your typings instead of the flow typings I had written originally.

One thing that I'm not sure about the best way to handle is the constants provided by mapkit (map type, or FeatureVisibility as examples).

I could change these to just be normal strings but if possible a user should be required to pass in something like mapkit.FeatureVisibility.Adaptive? I'm fairly new to typescript so any suggestions are super helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant