You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before submitting an issue please check that you’ve completed the following steps:
Yes - Made sure you’re on the latest version
Yes - Used the search feature to ensure that the bug hasn’t been reported before
Describe the bug
When calling rocket_update_option programmatically, if our Cloudflare addon is active, but the connection fails (for example if fields are empty) we produce a fatal error when calling WordPress core function add_settings_error because is not defined:
Before submitting an issue please check that you’ve completed the following steps:
Yes - Made sure you’re on the latest version
Yes - Used the search feature to ensure that the bug hasn’t been reported before
Describe the bug
When calling
rocket_update_option
programmatically, if our Cloudflare addon is active, but the connection fails (for example if fields are empty) we produce a fatal error when calling WordPress core functionadd_settings_error
because is not defined:wp-rocket/inc/Addon/Cloudflare/Subscriber.php
Line 632 in 7999ed2
The fatal error:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
This scenario is kinda edgy, but we could check if
add_settings_error
is defined here to prevent the error:Additional context
Ticket: https://secure.helpscout.net/conversation/2685627480/508599/
Slack Thread: https://wp-media.slack.com/archives/C08N8J6VC/p1724406001657579
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: