Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessing Quality of Nighttime Lights Data #23

Merged
merged 13 commits into from
Dec 7, 2023
Merged

Assessing Quality of Nighttime Lights Data #23

merged 13 commits into from
Dec 7, 2023

Conversation

ramarty
Copy link
Contributor

@ramarty ramarty commented Dec 4, 2023 •
edited
Loading

  • Update logo
  • Cleanup some of the documentation
  • Change input from roi_sf to roi (roi_sf only makes sense for R)
  • Add notebook about assessing NTL quality (eg, cloud cover, temporal gap, etc)
  • For daily data, fix masking with NA to only relevant NTL variables
  • Fix error when downloading non NTL data (eg, number of observations) for monthly and annual data

@g4brielvs
Copy link
Member

g4brielvs commented Dec 4, 2023 •
edited
Loading

Thanks @ramarty! I'm working on #24 and I'll merge the edits alongside the new parallel downloader. And thanks for fixing #14!

@g4brielvs g4brielvs added the enhancement New feature or request label Dec 4, 2023
@g4brielvs
Copy link
Member

g4brielvs commented Dec 6, 2023 •
edited
Loading

@ramarty Thanks! FYI I just pushed #25 (which adds some substantial changes under the hood). I'll resolve all the conflicts and bring in the changes from this PR. Please let me know when this PR is ready to review. And thanks a lot again!

@g4brielvs g4brielvs added this to the v0.2.0 milestone Dec 6, 2023
@g4brielvs g4brielvs self-requested a review December 6, 2023 22:25
@g4brielvs g4brielvs changed the title Rob edits Assessing Quality of Nighttime Lights Data Dec 7, 2023
@g4brielvs g4brielvs mentioned this pull request Dec 7, 2023
Closed
5 tasks
@g4brielvs g4brielvs merged commit 1b80afc into main Dec 7, 2023
1 check passed
@g4brielvs g4brielvs mentioned this pull request Dec 7, 2023
Closed
@g4brielvs g4brielvs deleted the rob-edits branch December 7, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g4brielvs g4brielvs g4brielvs approved these changes

Assignees

@g4brielvs g4brielvs

@ramarty ramarty

Labels
enhancement New feature or request
Projects
Enhancement Proposals for World Bank's GitHub Presence
Status: Done
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ramarty @g4brielvs