Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Picker and fix state update on an unmounted component #1054

Closed
wants to merge 4 commits into from
Closed

Refactor Picker and fix state update on an unmounted component #1054

wants to merge 4 commits into from

Conversation

Tug
Copy link
Contributor

@Tug Tug commented May 31, 2019 •
edited
Loading

Fixes #1049

Gutenberg PR: WordPress/gutenberg#15937

To test:

  • Try on WPAndroid and WPiOS
  • Try every components that use the Picker: the block picker, the link editor, the image add and edit... and check that the modal shows and dismiss as expected and the value picked is the right one

@Tug Tug added this to the v1.7 milestone May 31, 2019
@Tug Tug requested a review from daniloercoli May 31, 2019 11:31
@Tug Tug self-assigned this May 31, 2019
@Tug Tug mentioned this pull request May 31, 2019
Closed
5 tasks
@etoledom etoledom self-requested a review June 6, 2019 20:13
@Tug Tug requested a review from pinarol June 7, 2019 17:20
@etoledom etoledom modified the milestones: v1.7, v1.8 Jun 10, 2019
@hypest
Copy link
Contributor

hypest commented Jun 27, 2019

Bumping to next milestone since it is still WIP.

@hypest hypest modified the milestones: v1.8, 1.9 Jun 27, 2019
@Tug Tug modified the milestones: 1.9, 1.10 Jul 8, 2019
@hypest hypest modified the milestones: 1.10, 1.11 Jul 26, 2019
@etoledom etoledom modified the milestones: 1.11, 1.12 Aug 26, 2019
@hypest hypest removed this from the 1.12 milestone Oct 10, 2019
@Tug
Copy link
Contributor Author

Tug commented Nov 20, 2019

Closed per WordPress/gutenberg#15937

@Tug Tug closed this Nov 20, 2019
@Tug Tug deleted the fix/warning-media-picker-unmounted branch November 20, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@etoledom etoledom Awaiting requested review from etoledom

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@Tug Tug

Labels
bugfix [Type] Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media Picker - Warning - can't perform state update on an unmounted component
3 participants
@Tug @hypest @etoledom