Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border on Title when focused in order to match other block focus styles #540

Closed
iamthomasbishop opened this issue Feb 5, 2019 · 1 comment · Fixed by #622
Closed
Assignees
Labels
[Type] Enhancement Improves a current area of the editor
Milestone

Comments

@iamthomasbishop
Copy link
Contributor

When the Title is focused, it doesn't use the same styling (border) as all other blocks. We need to update this to match.

Current State

Title focused:

vs. other type of block:

Proposed

image

Note: The way the Title currently sits in the editor, the border-top might not be visible. For the sake of simplicity and consistency with all other block types, let's match the styling (border: 1px solid ... on all four sides).

@diegoreymendez diegoreymendez added this to the Beta milestone Feb 5, 2019
@diegoreymendez diegoreymendez added the [Type] Enhancement Improves a current area of the editor label Feb 5, 2019
@iamthomasbishop
Copy link
Contributor Author

@diegoreymendez I can't remember if we discussed already, but if possible (and not already solved as part of this issue, can we also make sure the placeholder text label color (when there is no title) is $gray aka #87a6bc? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants