Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RichText]: when editable is focused, tapping on toolbar actions switches focus #292

Closed
mzorz opened this issue Nov 28, 2018 · 1 comment
Labels
[Type] Bug Something isn't working Writing Flow

Comments

@mzorz
Copy link
Contributor

mzorz commented Nov 28, 2018

When a RichText component has the caret blinking and its block is selected, tapping on its toolbar actions do not work as expected - instead focus changes to next focusable item available.

To test:

  1. launch the demo app from scratch
  2. Tap on a RichText block: "Welcome to Gutenberg" (particularly, tap somewhere within the "Gutenberg" word, to leave space to avoid collision with up/down arrows next steps)
  3. observe the caret appears, the block gets selected, the keyboard appears and the editor toolbar reflects the Heading style
  4. try tapping on the DOWN arrow.
  5. observe the next block ("Hello World") gets the focus and is selected.

If you continue, the next available focusable items will get focused, for example:

  1. from the previous state left in step 5, try tapping on the DOWN arrow on this new block (Hello World).
  2. observe the next RichText block now gets the focus (jumping from Page Break block, to Lorem ipsum block).

What should happen?

  1. when a block gets selected, its inline toolbar actions should be actionable.
  2. if the block is editable, it should also show the keyboard and allow editing / moving caret / copy/paste, etc.

Where

Observed on a real device (Google Pixel 8.1)

@mzorz mzorz added [Type] Bug Something isn't working Writing Flow labels Nov 28, 2018
@koke koke mentioned this issue Nov 28, 2018
12 tasks
@mzorz
Copy link
Contributor Author

mzorz commented Nov 29, 2018

Closing, as this is not reproduceable anymore once wordpress-mobile/react-native-aztec#84 and this #296 get merged

@mzorz mzorz closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working Writing Flow
Projects
None yet
Development

No branches or pull requests

1 participant