Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size UI control for Gallery block #1921

Closed
mkevins opened this issue Feb 17, 2020 · 2 comments
Closed

Image size UI control for Gallery block #1921

mkevins opened this issue Feb 17, 2020 · 2 comments
Labels
Media [Type] Enhancement Improves a current area of the editor

Comments

@mkevins
Copy link
Contributor

mkevins commented Feb 17, 2020

Description

A PR was recently merged (WordPress/gutenberg#19232) which introduced a new Cycle Picker component. It is used for cycling through the image size options within the Image block settings.

For Gallery block, it would be good to have a consistent UI with the Image block, so this issue is open to consider this change for Gallery as well, which is currently using a Select control for the image size setting.

One consideration I have for this kind of UX is for users with low bandwidth and / or poor connectivity. In earlier tests with Gallery image size options, I noticed that when I change size options, I must wait for a new file to download (each size option must be cached individually). This means that to change sizes with a cycle picker, the user may be required to download all sizes to their device as they cycle through them.

Another consideration is consistency between the native and web implementations of the Gallery block settings. A point was recently raised regarding platform divergence on a different settings component which may be applicable here as well.

It may be necessary to find a way to optimize image loading for Gallery images before implementing a Cycle picker, and I think it's worth some design consideration for how that might look on web as well.

@mkevins mkevins added [Type] Enhancement Improves a current area of the editor Media labels Feb 17, 2020
@jhnstn
Copy link
Member

jhnstn commented Feb 23, 2022

The image size selection has changed since this was opened and both the Gallery and Image block are now consistent

Image

gallery-block-size.mp4

##Gallery
https://user-images.githubusercontent.com/744755/155342883-a16afe50-4e84-46ed-a45a-e4628b848ee1.mp4

I'm closing since the primary focus on the issue — UI inconsistencies — is now outdated.

The other concerns about the UI should be brought up in a new issue.

@jhnstn jhnstn closed this as completed Feb 23, 2022
@mkevins
Copy link
Contributor Author

mkevins commented Feb 24, 2022

The other concerns about the UI should be brought up in a new issue.

Actually, I believe the other concerns have been addressed since this issue was opened. At least, from your video, it seems that the cycle picker is no longer being used (which was the source of the issue mentioned). Thanks for circling back to this @jhnstn 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

No branches or pull requests

2 participants