Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap to write #166

Closed
koke opened this issue Oct 17, 2018 · 10 comments
Closed

Tap to write #166

koke opened this issue Oct 17, 2018 · 10 comments
Milestone

Comments

@koke
Copy link
Member

koke commented Oct 17, 2018

When the user taps into a text block, they should start editing right away with the cursor in the position they tapped, even if it's not the currently selected block.

@koke koke added this to the Alpha milestone Oct 17, 2018
@koke koke mentioned this issue Oct 18, 2018
4 tasks
@koke
Copy link
Member Author

koke commented Oct 22, 2018

@diegoreymendez @daniloercoli can you update this one by Wednesday with what we need to do to ensure this and how much it should take?

@koke
Copy link
Member Author

koke commented Oct 23, 2018

Let's also consider #135 as part of this

@daniloercoli
Copy link
Contributor

There are a couple of problems with focus handling on the Android side.
I know @mzorz was working on a fix for them, but I'm not quite sure the current state of the fix. IIRC the problem was with our react-native-recyclerview-list implementation, that was acting badly under some circumstances.
Once those "focus" problems are solved, I think we need to modify Aztec + Aztec Wrapper to correctly move the cursor to the position tapped by the user.

@diegoreymendez
Copy link
Contributor

It's a bit complicated because I'm not sure what's needed for this. But assuming:

  • Discovery work to learn what's necessary. (1 day)
  • Initial implementation. (2 days)
  • Testing / fixing issues (1 or 2 days)

I'd say 5 days would be my initial estimation.

Does this work for you @koke?

@diegoreymendez diegoreymendez self-assigned this Oct 23, 2018
@diegoreymendez
Copy link
Contributor

Actually @koke, I assumed work was necessary in iOS, but it seems like it works out of the box.

Can you review and confirm if this behavior is fine for the purpose of this issue?

taptoeditios

@koke
Copy link
Member Author

koke commented Oct 24, 2018

@diegoreymendez yeah, that looks like it works as expected. Great news 👏

@koke
Copy link
Member Author

koke commented Oct 24, 2018

After chatting with @daniloercoli, this also seems to be working on Android and should be ok once we fix #135

@koke
Copy link
Member Author

koke commented Oct 24, 2018

After chatting with @mzorz we are estimating 3 days for #135, although he might come up with a better estimate after more research today.

@diegoreymendez
Copy link
Contributor

I removed myself from the assignment since there's nothing else I can do for this task right now.

@koke
Copy link
Member Author

koke commented Oct 26, 2018

Keeping track of all focus-related issues in #196

@koke koke closed this as completed Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants