Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icon component to allow better customization for mobile #1004

Closed
pinarol opened this issue May 20, 2019 · 0 comments · Fixed by #1017 or WordPress/gutenberg#15778
Closed

Update Icon component to allow better customization for mobile #1004

pinarol opened this issue May 20, 2019 · 0 comments · Fixed by #1017 or WordPress/gutenberg#15778
Assignees
@pinarol
Labels
[OS] Android [OS] iOS [Type] Technical Debt

Comments

@pinarol
Copy link
Contributor

pinarol commented May 20, 2019 •
edited
Loading

Currently we can't pass styles to Icon component for our own needs. It only accepts className and it is not applied for mobile. Let's update Icon component to allow this and then refactor src/block-management/block-picker.js to remove iconWithUpdatedFillColor function.

This looks like a tech debt but actually it is more important than that. It can cause some side affects as #997

cc @Tug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinarol pinarol

Labels
[OS] Android [OS] iOS [Type] Technical Debt
Projects
None yet
Milestone
No milestone
1 participant
@pinarol