-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 결제 실패 시 복구 로직을 수행한다. #114
Conversation
order 시 Placed 상태 변화 단위테스트 필요
src/main/java/com/woowa/woowakit/domain/order/domain/OrderPayService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다.
src/main/java/com/woowa/woowakit/domain/order/domain/OrderPlaceService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/woowa/woowakit/domain/order/domain/OrderStatus.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿굿 동기적 접근
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모두 확인 완료입니다!
고생하셨어요!
Description
#108 에 명시된 대로 복구 로직을 수행합니다.
기존 @async로 비동기 메서드를 호출하던 방식에서, 반환받은 Mono stream을 subscribe하여 ElasticBound 스레드에서 DB 업데이트를 하는 것으로 방식을 변경하였습니다.
Payment와 Order가 억지로 분리된 듯한 느낌을 계속 받습니다. Payment를 Order의 Value Object로 관리하는 것에 대해 고민해볼 필요가 있을 듯 합니다.
Changes
커밋 로그 확인 요망
Test Checklist