feat: 결제 실패 시 복구 로직을 수행한다. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
order 시 Placed 상태 변화 단위테스트 필요
chanwooDev
reviewed
Aug 29, 2023
src/main/java/com/woowa/woowakit/domain/order/domain/OrderPayService.java
Outdated
Show resolved
Hide resolved
chanwooDev
reviewed
Aug 29, 2023
src/main/java/com/woowa/woowakit/domain/order/domain/OrderPlaceService.java
Outdated
Show resolved
Hide resolved
chanwooDev
reviewed
Aug 29, 2023
src/main/java/com/woowa/woowakit/domain/order/domain/OrderStatus.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#108 에 명시된 대로 복구 로직을 수행합니다.
기존 @async로 비동기 메서드를 호출하던 방식에서, 반환받은 Mono stream을 subscribe하여 ElasticBound 스레드에서 DB 업데이트를 하는 것으로 방식을 변경하였습니다.
Payment와 Order가 억지로 분리된 듯한 느낌을 계속 받습니다. Payment를 Order의 Value Object로 관리하는 것에 대해 고민해볼 필요가 있을 듯 합니다.
Changes
커밋 로그 확인 요망
Test Checklist