Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli exec fail on warning linting error but it should only be logged #3821

Closed
6543 opened this issue Jun 22, 2024 · 4 comments · Fixed by #3868
Closed

cli exec fail on warning linting error but it should only be logged #3821

6543 opened this issue Jun 22, 2024 · 4 comments · Fixed by #3868
Labels
bug Something isn't working cli

Comments

@6543
Copy link
Member

6543 commented Jun 22, 2024

woodpecker version: v2.6.0

cli exec with this config:

steps:
  - name: echo
    image: dummy
    commands: echo ja

we get:

8:38PM DBG cli/common/hooks.go:38 > Checking for updates ...
8:38PM DBG cli/update/updater.go:25 > Current version: next-1f21033432
8:38PM DBG cli/update/updater.go:28 > Skipping update check for development & next versions
8:38PM DBG cli/common/hooks.go:49 > No update required
8:38PM FTL cmd/cli/main.go:27 > error running cli error="[bad_habit] Please set an event filter for all steps or the whole workflow on all items of the when block"

I expect the cli to not fail just lock the error - as error type is bad_habit

Originally posted by @6543 in #3820 (comment)

@6543 6543 added cli regression fix a bug that was not released yet bug Something isn't working and removed regression fix a bug that was not released yet labels Jun 22, 2024
@6543
Copy link
Member Author

6543 commented Jun 22, 2024

-> to simulate what server+agent would do

@6543 6543 mentioned this issue Jun 22, 2024
1 task
@anbraten
Copy link
Member

anbraten commented Jul 3, 2024

Running go run ./cmd/cli/ lint test.yml with the provided config returns:

🔥 jo.yml has warnings / errors:
   ⚠️  Please set an event filter for all steps or the whole workflow on all items of the when block

with exit code 0 in my case.

@6543
Copy link
Member Author

6543 commented Jul 3, 2024

Yes and now try to exec it

@anbraten
Copy link
Member

anbraten commented Jul 3, 2024

Just noticed that 😅 Fix is almost done 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants