Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Investigate WooCommerce Blocks dependencies that use lodash #45701

Open
4 tasks
ralucaStan opened this issue Mar 19, 2024 · 2 comments
Open
4 tasks

[Task]: Investigate WooCommerce Blocks dependencies that use lodash #45701

ralucaStan opened this issue Mar 19, 2024 · 2 comments
Labels
focus: performance The issue/PR is related to performance. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@ralucaStan
Copy link
Contributor

ralucaStan commented Mar 19, 2024 •
edited
Loading

Problem to solve

When executing pnpm why lodash --prod in the woocommerce/plugins/woocommerce-blocks folder of the WC monorepo, it looks like lodash is being pulled in for usage of @wordpress/components v14.2.0, @wordpress/compose v5.5.0, @wordpress/notices v3.12.0, @wordpress/server-side-render v3.10.0 and @wordpress/data v6.15.0.

Screenshot 2024-03-19 at 11 08 04

Lodash was removed from removed from WordPress packages WordPress/gutenberg#17025 so we need to update the versions of the libraries listed above.

Note: @wordpress/components will be ignored as we are working on removing it via #45571.

Goal of this ticket

  • Update @wordpress/compose (npm)
  • Update @wordpress/notices (npm)
  • Update @wordpress/server-side-render (npm)
  • Update @wordpress/data (npm)
  1. investigate the update of the packages above
  2. if any package needs more investigation due to breaking changes create a separate ticket and add the ticket link to it's task
  3. proceed with updating the dependencies

This ticket should be handled as part of the Porter rotation

Describe alternatives you've considered

No response

Additional context

p6JqRr-c8r-p2#comment-18037
@ralucaStan ralucaStan added priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team). team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues focus: performance The issue/PR is related to performance. labels Mar 19, 2024
@ralucaStan ralucaStan changed the title [Enhancement]: Investigate WooCommerce Blocks dependencies that use lodash [Task]: Investigate WooCommerce Blocks dependencies that use lodash Mar 19, 2024
@ralucaStan ralucaStan added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. and removed priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. labels Mar 19, 2024
@ralucaStan ralucaStan removed the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Apr 22, 2024
@ralucaStan
Copy link
Contributor Author

ralucaStan commented Apr 22, 2024 •
edited
Loading

I'm adding priority normal to this issue. Context pcShBQ-1Ly-p2

@ralucaStan ralucaStan added the priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. label Jun 6, 2024
@mikejolley
Copy link
Member

Note there are some unfinished tasks around components #45571 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: performance The issue/PR is related to performance. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikejolley @ralucaStan