Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Hooks API: Abstract Mini Cart logic #43266

Closed
Tracked by #42745
tjcafferkey opened this issue Jan 4, 2024 · 0 comments · Fixed by #43250
Closed
Tracked by #42745

Block Hooks API: Abstract Mini Cart logic #43266

tjcafferkey opened this issue Jan 4, 2024 · 0 comments · Fixed by #43250
Assignees
@tjcafferkey
Labels
block: mini-cart Issues related to the Mini-Cart block. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami WC Store Editing (FSE)

Comments

@tjcafferkey
Copy link
Contributor

tjcafferkey commented Jan 4, 2024 •
edited
Loading

As part of issue woocommerce/woocommerce-blocks#11745 there was some Block Hooks API logic added to the Mini Cart class to auto-insert it into the header of TT4 (and now other approved themes).

We should abstract this logic into the parent class so it can be utilised by other blocks (e.g. Customer block)
@tjcafferkey tjcafferkey mentioned this issue Jan 4, 2024
Closed
@tjcafferkey tjcafferkey self-assigned this Jan 4, 2024
@tjcafferkey tjcafferkey added team: Kirigami & Origami WC Store Editing (FSE) block: mini-cart Issues related to the Mini-Cart block. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jan 4, 2024
@tjcafferkey tjcafferkey mentioned this issue Jan 4, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjcafferkey tjcafferkey

Labels
block: mini-cart Issues related to the Mini-Cart block. plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Kirigami & Origami WC Store Editing (FSE)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Hooks API: Abstract Block Hooks code into a separate trait class woocommerce/woocommerce
1 participant
@tjcafferkey