Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Use SF symbols for icons, not images #13458

Closed
joshheald opened this issue Jul 30, 2024 · 2 comments · Fixed by #13649
Closed

[Woo POS] Use SF symbols for icons, not images #13458

joshheald opened this issue Jul 30, 2024 · 2 comments · Fixed by #13649
Assignees
Labels
feature: POS type: task An internally driven task.

Comments

@joshheald
Copy link
Contributor

Description

I've noticed some icons we're using are added as images, but could be used as SF symbols – e.g.

arrow.uturn.backward for the arrow in on the New Transaction button:

Image

rectangle.portrait.and.arrow.forward for the Exit POS button

Image

Same for dismissing products banner, getting support, removing an item from the cart. Check the images in the POS folder for any icon-like images, remove and replace at the callsites.

Using SF symbols removes code, and makes sure the images are appropriate for both LTR and RTL locales.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Jul 30, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 30, 2024

Thanks for reporting! 👍

@iamgabrielma
Copy link
Contributor

The SFSymbol for the CartView's back button has been handled here: #13631

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants