[Woo POS] Add simple-only product banner to dashboard #13319
Conversation
|
|
| @@ -37,6 +34,63 @@ struct ItemListView: View { | |||
| /// View Helpers | |||
| /// | |||
| private extension ItemListView { | |||
| @ViewBuilder | |||
There was a problem hiding this comment.
Thoughts on using ViewBuilder vs computed variables for the views? I tend to use the first one if there's some conditional logic or we need to pass params, but doesn't seem to be needed for all cases 🤔
There was a problem hiding this comment.
You can put @ViewBuilder for both functions and computed variables
| } | ||
| VStack { |
There was a problem hiding this comment.
I would insert a Spacer here between the text and the close button to make sure that the button is pushed on the right side and text and all the content on the left is pushed on the left:
There was a problem hiding this comment.
Sounds good. Updated dc3bc34
| .background(Color.posBackgroundWhitei3) | ||
| } | ||
|
|
||
| var headertextView: some View { |
There was a problem hiding this comment.
Fixed: f62db85
| var headertextView: some View { | ||
| Text(Localization.productSelectorTitle) | ||
| .frame(maxWidth: .infinity, alignment: .leading) | ||
| .padding(.vertical, 8) |
There was a problem hiding this comment.
Maybe we can also have this 8 in Constants
There was a problem hiding this comment.
Yep! Moved on 196451f
Closes: #13317
Description
This PR adds a toggeable banner to the header of the item list view, in order to the current POS constraint for simple products only.
Please note the UI is not final yet, so we haven't addressed the fine-tuned details, just the overall view and its behaviour. In future PRs we also want to tie the banner display to once per app-install, at the moment will just appear all the time by default on init.
Testing
xicon and observe it collapses. Tap theiicon and observe it expands again.