Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] M2 UI: Native Pull-to-refresh #13286

Closed
iamgabrielma opened this issue Jul 10, 2024 · 7 comments · Fixed by #13660
Closed

[Woo POS] M2 UI: Native Pull-to-refresh #13286

iamgabrielma opened this issue Jul 10, 2024 · 7 comments · Fixed by #13660
Assignees
Labels
feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

iamgabrielma commented Jul 10, 2024

Updated Description

Make sure native pull to refresh functionality works on Woo POS.

Description

We don't want to reuse #13143 fully when refreshing data, as the designs are intended for entering POS mode, but we can reuse and simplify the same view for its purpose.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Jul 10, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jul 10, 2024

Thanks for reporting! 👍

@joshheald
Copy link
Contributor

We don't want to reuse [the fullscreen POS mode loading view] fully when refreshing data, as the designs are intended for entering POS mode, but we can reuse and simplify the same view for its purpose.

I'm not sure about that approach, is that what @joe-keenan has mentioned? I can't see it in the designs anywhere.

I wouldn't expect the products to be covered/lost when pulling to refresh, it makes things feel a little broken... surely we should just show a loading indicator at the top of the products list after it's pulled down, like normal?

@joe-keenan
Copy link

Yeah, I didn’t define it because I thought it was just a standard native behaviour. Would you like me to detail it in the designs?

@joshheald
Copy link
Contributor

@joe-keenan no it's fine, I can see this in the designs now:

CleanShot 2024-07-31 at 08 31 38@2x

TfaZ4LUkEwEGrxfnEFzvJj-fi-2996_17982

That covers it (though the SF symbol and timestamp aren't built in, AFAIK.)

@joe-keenan
Copy link

Yeah, I’m not surprised. That’s what I assumed.

I’d like to add the timestamp there, but I’m happy to compromise on the symbol – since it would be great if it animated. Sort of like a lite-version of what Pocket Casts does. If it’s too time consuming to get the arrow spinning, then I’m happy to stick with the stock spinner.

RPReplay_Final1722470622.mov

@AnirudhBhat
Copy link

After discussing this on Slack, we've come to conclusion that we will be going with native components on both the platforms for the POC

p1722580592828269-slack-C070SJRA8DP

@staskus
Copy link
Collaborator

staskus commented Aug 2, 2024

I reopen this task, we still need to deal with some technicalities on iOS for pull-to-refresh.

@staskus staskus changed the title [Woo POS] M2 UI: Pull-to-refresh loading screen [Woo POS] M2 UI: Native Pull-to-refresh Aug 2, 2024
@staskus staskus reopened this Aug 2, 2024
@staskus staskus self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants