-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] M2 UI: Native Pull-to-refresh #13286
Comments
Thanks for reporting! 👍 |
I'm not sure about that approach, is that what @joe-keenan has mentioned? I can't see it in the designs anywhere. I wouldn't expect the products to be covered/lost when pulling to refresh, it makes things feel a little broken... surely we should just show a loading indicator at the top of the products list after it's pulled down, like normal? |
Yeah, I didn’t define it because I thought it was just a standard native behaviour. Would you like me to detail it in the designs? |
@joe-keenan no it's fine, I can see this in the designs now: TfaZ4LUkEwEGrxfnEFzvJj-fi-2996_17982 That covers it (though the SF symbol and timestamp aren't built in, AFAIK.) |
Yeah, I’m not surprised. That’s what I assumed. I’d like to add the timestamp there, but I’m happy to compromise on the symbol – since it would be great if it animated. Sort of like a lite-version of what Pocket Casts does. If it’s too time consuming to get the arrow spinning, then I’m happy to stick with the stock spinner. RPReplay_Final1722470622.mov |
After discussing this on Slack, we've come to conclusion that we will be going with native components on both the platforms for the POC p1722580592828269-slack-C070SJRA8DP |
I reopen this task, we still need to deal with some technicalities on iOS for pull-to-refresh. |
Updated Description
Make sure native pull to refresh functionality works on Woo POS.
Description
We don't want to reuse #13143 fully when refreshing data, as the designs are intended for entering POS mode, but we can reuse and simplify the same view for its purpose.
The text was updated successfully, but these errors were encountered: