Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] M2: Handle product edge cases #13243

Closed
iamgabrielma opened this issue Jul 4, 2024 · 4 comments
Closed

[Woo POS] M2: Handle product edge cases #13243

iamgabrielma opened this issue Jul 4, 2024 · 4 comments
Labels
feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

iamgabrielma commented Jul 4, 2024

The current limitation is to use simple physical products only, but there's some other criteria within simple products that we should test and take into account. For example:

  • Products without price should be non eligible
Screenshot 2024-07-04 at 14 20 59
  • What price we'll be showing when a product has:
    • price
    • regularPrice
    • salePrice
  • What if purchasable is false? Should be eligible or not?
  • soldIndividually? Part of a bundle? etc, ...
@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Jul 4, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@iamgabrielma
Copy link
Contributor Author

P2: pdfdoF-5d5-p2

@joshheald
Copy link
Contributor

joshheald commented Aug 7, 2024

Is this done with #13503 @iamgabrielma ? I don't think it is, but they're in the same area so wanted to check.

@iamgabrielma
Copy link
Contributor Author

Thanks for following up. I'll close this one: The main changes regarding eligibility were done on #13503, and #13522. The remaining item for the different prices has been logged as low priority on #13502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

No branches or pull requests

3 participants