Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Floating toolbar #11994

Merged
merged 15 commits into from
Jul 16, 2024
Merged

[Woo POS] Floating toolbar #11994

merged 15 commits into from
Jul 16, 2024

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jul 12, 2024

Closes: #11992

Description

  • Makes toolbar floating
  • Adds animation on the state changes
  • Removes statuses that are not in use anymore as per design
  • Fixes bug when it was possible to rotate the screen during connection/payment flow

Unfortunately, there are more potential changes to the toolbar, so another iteration could be needed to match the final design 😭

p1720798932846349/1720798863.793069-slack-C070SJRA8DP

image

Testing information

Use the floating toolbar. Notice the animation

Images/gif

07-15--11-58.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@kidinov kidinov linked an issue Jul 12, 2024 that may be closed by this pull request
@kidinov kidinov added the feature: point of sale POS project label Jul 12, 2024
@kidinov kidinov marked this pull request as draft July 12, 2024 14:53
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 12, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit6f87816
Direct Downloadwoocommerce-wear-prototype-build-pr11994-6f87816.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 12, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit6f87816
Direct Downloadwoocommerce-prototype-build-pr11994-6f87816.apk

@kidinov kidinov added this to the 19.6 milestone Jul 15, 2024
@kidinov kidinov marked this pull request as ready for review July 15, 2024 10:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 1.20482% with 82 lines in your changes missing coverage. Please review.

Project coverage is 40.00%. Comparing base (56453a6) to head (6f87816).
Report is 15 commits behind head on trunk.

Files Patch % Lines
.../android/ui/woopos/root/WooPosRootBottomToolbar.kt 0.00% 71 Missing ⚠️
.../android/ui/woopos/common/composeui/WooPosTheme.kt 0.00% 10 Missing ⚠️
...erce/android/ui/woopos/root/WooPosRootViewModel.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11994      +/-   ##
============================================
- Coverage     40.01%   40.00%   -0.02%     
+ Complexity     5432     5431       -1     
============================================
  Files          1184     1184              
  Lines         67012    67026      +14     
  Branches       9335     9343       +8     
============================================
- Hits          26814    26812       -2     
- Misses        37708    37723      +15     
- Partials       2490     2491       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backwardstruck backwardstruck self-assigned this Jul 15, 2024
Copy link
Contributor

@backwardstruck backwardstruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Testing...

Copy link
Contributor

@backwardstruck backwardstruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on tablet emulator.

@kidinov kidinov merged commit d6c5925 into trunk Jul 16, 2024
16 checks passed
@kidinov kidinov deleted the 11992-woo-pos-make-toolbar-floating branch July 16, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Make toolbar floating
4 participants