-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Floating toolbar #11994
[Woo POS] Floating toolbar #11994
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/root/WooPosRootScreen.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11994 +/- ##
============================================
- Coverage 40.01% 40.00% -0.02%
+ Complexity 5432 5431 -1
============================================
Files 1184 1184
Lines 67012 67026 +14
Branches 9335 9343 +8
============================================
- Hits 26814 26812 -2
- Misses 37708 37723 +15
- Partials 2490 2491 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. Testing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on tablet emulator.
Closes: #11992
Description
Unfortunately, there are more potential changes to the toolbar, so another iteration could be needed to match the final design 😭
p1720798932846349/1720798863.793069-slack-C070SJRA8DP
Testing information
Use the floating toolbar. Notice the animation
Images/gif
07-15--11-58.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.