Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a decimal separator other than dot may cause shipping data not to be synced #2470

Open
eason9487 opened this issue Jul 15, 2024 · 0 comments · May be fixed by #2527
Open

Using a decimal separator other than dot may cause shipping data not to be synced #2470

eason9487 opened this issue Jul 15, 2024 · 0 comments · May be fixed by #2527
Assignees
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@eason9487
Copy link
Member

Describe the bug:

If the decimal separator in WooCommerce core currency options is not . and shipping data is obtained from WooCommerce core, the shipping data may not be synced to Google Merchant Center.

This issue occurs in all relevant fields:

  • Single shipping cost
  • Shipping class costs
  • Free shipping threshold

Steps to reproduce:

  1. Go to WooCommerce > Settings > General and set the decimal separator in the currency options to ,.
    image
  2. Go to WooCommerce > Settings > Shipping > Shipping zones and set up a zone with:
    • Free shipping and minimum order amount, e.g. 999,99
      image
    • Flat rate with single cost or class costs.
      image
  3. Go to edit free listings.
  4. Select the Recommended: Automatically sync my store’s shipping settings to Google option for the shipping rates setting.
  5. Add the above configured zone to the Audience setting.
  6. Save changes.
  7. Wait a moment for the settings to sync to Google Merchant Center.
  8. Go to Google Merchant Center and navigate to Shipping and returns page.
  9. No shipping data has been synchronized to Shipping policies.

image

Expected behavior:

The shipping costs should be parsed according to the currency options set in the WooCommerce core and synced correctly to Google Merchant Center.

Actual behavior:

The shipping costs may not be parsed and omitted to sync to Google Merchant Center when the decimal separator in WooCommerce core currency options is not using ..

Additional details:

How WooCommerce core handles amount formatting: https://github.com/woocommerce/woocommerce/blob/9.0.2/plugins/woocommerce/includes/shipping/flat-rate/class-wc-shipping-flat-rate.php#L108-L115

@eason9487 eason9487 added type: bug The issue is a confirmed bug. impact: high This issue impacts a lot of users as reported by our Happiness Engineers. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. and removed impact: high This issue impacts a lot of users as reported by our Happiness Engineers. labels Jul 15, 2024
@ianlin ianlin self-assigned this Aug 9, 2024
@mikkamp mikkamp linked a pull request Aug 15, 2024 that will close this issue
@jorgemd24 jorgemd24 linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants