Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Phone Number Input from @woocommerce/components #2429

Open
mikkamp opened this issue Jun 13, 2024 · 0 comments
Open

Use Phone Number Input from @woocommerce/components #2429

mikkamp opened this issue Jun 13, 2024 · 0 comments
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@mikkamp
Copy link
Contributor

mikkamp commented Jun 13, 2024

User story

WooCommerce added a Phone Number input component in @woocommerce/components which includes validation. It took a while before it was fully available in WC L-2 but now that it's been around for more than 6 months we shouldn't have a problem with support. Would we benefit from reusing this instead of a custom component?

Potential benefits:

  • Could reduce the bundle size
  • Less code to maintain within the extension
  • Standardization so that all phone number inputs are the same across WooCommerce

See details about the component: https://github.com/woocommerce/woocommerce/tree/trunk/packages/js/components/src/phone-number-input

Additional details:

pcShBQ-19W-p2

@mikkamp mikkamp added the type: enhancement The issue is a request for an enhancement. label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

1 participant