-
Notifications
You must be signed in to change notification settings - Fork 494
Missing tsconfig.test.json when upgrading to v2.5.0 #141
Comments
Thanks for this detailed report! I will leave this open incase other users have the same issue, but as nobody else has come to report it I'm not sure they are. I will accept a PR to add to the README if this is indeed an issue experience by others. |
I just tried to upgrade a project from 2.3.2 to 2.6.0, and experienced the same issue, the tsconfig.test.json was not created during the upgrade: Every test failed with:
|
I have this problem after upgrading from typescript 2.4.2 to 2.5.0 on windows, with yarn 0.27. |
I've also had this same problem |
It seems that indeed this is not an issue isolated to me. I'll work on a PR soon. |
In my case helped changing path to test config file, I found that line in my package.json file:
I just removed "/var/www/frontend/" line (on the other hand the path was correct when I was using docker to lunch my app via NPM). Probably this line is visible only after eject oryginal 'react-scripts-ts' (btw. procedure is described in readme). You've got to check it by your own, I hope it helps ;) |
NB: MAYBE ONLY A ONE TIME THING. SEE 'REPRODUCIBLE DEMO' SECTION!
Bug report
When ugrading
react-scripts-ts
from version2.4.0
to2.5.0+
the app wont start, because the filetsconfig.test.json
is missing from the project. This is probably related to #115 that adds support for this file. However when upgradingreact-scripts-ts
by bumping the version number inpackage.json
and runningyarn install
this file of course doesn't get created, and thus is missing.Environment
npm ls react-scripts-ts
: 2.6.0node -v
: 8.3.0npm -v
: 5.3.0yarn --version
: 0.27.5Then, specify:
Steps to Reproduce
2.4.0
or below of react-scripts-ts installed and working in a project2.5.0
or above inpackage.json
yarn install
ornpm install
yarn start
Expected Behavior
It should work
Actual Behavior
It crashes with an error saying that
tsconfig.test.json
is missing.Reproducible Demo
Honestly I can't reproduce this. I fixed the problem, and when I tried to delete the file to reproduce the problem, the error wouldn't happen, and everything worked. yet I'm still reporting this, to see if others are having similar issues, or can reproduce it.
How To Fix This
For reference to others, this is how I fixed this issue:
tsconfig.json
file) calledtsconfig.test.json
If this indeed is a bug that many are experiencing I would suggest one of these steps:
a. Write a migration guide in the README.md that explains how to fix this error when upgrading.
b. Output a useful error message, explaining how to fix the issue, possibly with a link to this issue.
c. Automatically create the file if it doesn't exist when the app is started. (not sure this is even possible)
The text was updated successfully, but these errors were encountered: