Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit button missing aria-describedby #41

Closed
wlabarron opened this issue May 22, 2021 · 0 comments · Fixed by #42
Closed

Submit button missing aria-describedby #41

wlabarron opened this issue May 22, 2021 · 0 comments · Fixed by #42
Assignees
@wlabarron
Labels
awaiting-release Issues which are closed in the next release branch, waiting to be merged to main enhancement New feature or request
Milestone
v1.1

Comments

@wlabarron
Copy link
Owner

The final Submit button says "Uploading" while a show is uploading, with some help text underneath to explain the button activates once the show has uploaded. The help text should be linked to the button somehow. I think aria-describedby is the best attribute for this, but should double check before implementing.
@wlabarron wlabarron added the enhancement New feature or request label May 22, 2021
@wlabarron wlabarron linked a pull request May 22, 2021 that will close this issue
Accessibility fixes #42
Merged
@wlabarron wlabarron self-assigned this May 22, 2021
@wlabarron wlabarron added this to the v1.1 milestone May 22, 2021
@wlabarron wlabarron added the awaiting-release Issues which are closed in the next release branch, waiting to be merged to main label Jul 24, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlabarron wlabarron

Labels
awaiting-release Issues which are closed in the next release branch, waiting to be merged to main enhancement New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Accessibility fixes wlabarron/submit-show
1 participant
@wlabarron