Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"base" option in combination with "trailingSlash: 'never'" leads to wrong URI for partytown #5935

Closed
1 task
AleVul opened this issue Jan 22, 2023 · 2 comments · Fixed by #5936
Closed
1 task

"base" option in combination with "trailingSlash: 'never'" leads to wrong URI for partytown #5935

AleVul opened this issue Jan 22, 2023 · 2 comments · Fixed by #5936

Comments

@AleVul
Copy link

AleVul commented Jan 22, 2023

What version of astro are you using?

1.9.2

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

linux

Describe the Bug

when configuring astro with base: '/blog' and trailingSlash: 'never' - generated url for partytown script is "/blog~partytown".

The build step also logs the following: (!) "base" option should end with a slash.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-npvowd?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@rishi-raj-jain
Copy link
Contributor

@AleVul I think this was fixed in 4266869

@rishi-raj-jain
Copy link
Contributor

Ah but that's an old one now

@rishi-raj-jain rishi-raj-jain mentioned this issue Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: trailingSlash with base breaking partytown file path
2 participants
@AleVul @rishi-raj-jain