fix: completions shown if cursor in right position #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if cursor is in correct position than add completionitems otherwise do nothing
|
works with my tests so far. please have a quick test with "F5" too. thx |
|
@voorjaar can we get high severity on this. as this seems to affect many users. If you approve. I will take heavy lifting of merging and release 💯 |
|
@alexanderniebuhr I can't get it verified on my machine, but it looks ok to me. If you believe it's important, I'd say just go ahead and release it. It's better to have a release that people can revert to old versions if it breaks anything rather than no options to choose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if cursor is in correct position than add completion items otherwise do nothing
closes #2