Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminators.py contains codepoints which are not sentence terminators #3

Closed
divec opened this issue Oct 22, 2023 · 0 comments · May be fixed by #4
Closed

terminators.py contains codepoints which are not sentence terminators #3

divec opened this issue Oct 22, 2023 · 0 comments · May be fixed by #4

Comments

@divec
Copy link

divec commented Oct 22, 2023

One of these is (U+123B Ethiopic Syllable Shaa) which appears in test_am.py:

"ቴዎድሮስ ጥር ፮ ቀን ፲፰፻፲፩ ዓ.ም. ሻርጌ በተባለ ቦታ ቋራ ውስጥ፣ ከጎንደር ከተማ በስተ ምዕራብ ተወለዱ።",
["ቴዎድሮስ ጥር ፮ ቀን ፲፰፻፲፩ ዓ.ም. ሻ", "ርጌ በተባለ ቦታ ቋራ ውስጥ፣ ከጎንደር ከተማ በስተ ምዕራብ ተወለዱ።"],

(The expected value should be one sentence, which would make the test currently fail). It looks like there are several other letter codepoints in the list too.

Also some of the codepoints have incorrect comments. E.g. the last item is U+1DA88 (Signwriting Full Stop) which is correctly in the list, but the comment inaccurately describes it as "Mathematical Bold Capital U".

divec added a commit to divec/sentencex that referenced this issue Oct 22, 2023
santhoshtr added a commit that referenced this issue Nov 1, 2023
Regenerate terminators using Unicode::Tussle

Fixes issue #3
santhoshtr added a commit that referenced this issue Nov 1, 2023
Regenerate terminators using Unicode::Tussle

Fixes issue #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants