Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Fix warning about Undefined variable $firstbookableday #1639

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

datengraben
Copy link
Contributor

Fixes a warning about undefined variable $firstbookableday in commonsbooking/src/View/Calendar.php (Line: 399)

Error code: E_WARNING
[Message]:
Undefined variable $firstbookableday

@hansmorb I don't really at the moment if null is a problem here for the JS client code, but it was null for calendars with no timeframes (see the if and the count in Line 363/364) in the past anyways, so I figured it should work this way.

@datengraben datengraben added quick issues with minor dependencies technical Non-functional changes (refactorings or increase test coverage) labels Oct 2, 2024
@datengraben datengraben added this to the 2.10 milestone Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.23%. Comparing base (4841327) to head (041b169).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1639   +/-   ##
=========================================
  Coverage     50.23%   50.23%           
  Complexity     2722     2722           
=========================================
  Files            99       99           
  Lines         10867    10868    +1     
=========================================
+ Hits           5459     5460    +1     
  Misses         5408     5408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansmorb hansmorb merged commit 1136aa1 into master Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick issues with minor dependencies technical Non-functional changes (refactorings or increase test coverage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants