added support for WP personal data exporter & eraser #1355 #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansmorb
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1356 +/- ##
============================================
+ Coverage 35.87% 36.36% +0.49%
- Complexity 2115 2134 +19
============================================
Files 83 83
Lines 8592 8734 +142
============================================
+ Hits 3082 3176 +94
- Misses 5510 5558 +48
|
datengraben
requested changes
Sep 21, 2023
…ancement/issue-1355
hansmorb
changed the title
datengraben
requested changes
Oct 21, 2023
src/Repository/Booking.php
Outdated
| * @param int $perPage The number of bookings per page. A lower number will result in faster queries. | ||
| * @param array $customArgs Valid WP_Query args array. | ||
| * | ||
| * @return array |
There was a problem hiding this comment.
Hier fehlt noch Model/Booking type annotation
src/Repository/Timeframe.php
Outdated
| @@ -84,6 +84,7 @@ public static function getBookableForCurrentUser( | |||
| * Why? We have different types of timeframes and in some cases we need multiple of them. | |||
| * In this case we need this function. | |||
| * Other functions use this one as base function for more specialized searches. | |||
| * This function is not based on the WP_Query class, probably because of performance reasons. | |||
There was a problem hiding this comment.
Vielleicht eher ein TODO Investigate 😆 würde mich aber auch mal interessieren.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.wordpress.org/plugins/privacy/adding-the-personal-data-exporter-to-your-plugin/
closes #1355
So sieht das dann im WP eigenen Export aus:
Auch ganz schön zu sehen, dass wenn der Artikel gelöscht wird das Feld für den Posttitel einfach leer bleibt.