Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DecodeString and Decode methods. #1

Merged
merged 3 commits into from
Nov 22, 2016
Merged

Optimize DecodeString and Decode methods. #1

merged 3 commits into from
Nov 22, 2016

Commits on Nov 18, 2016

  1. Optimize DecodeString and Decode methods. 

    In the DecodeString case it avoids unnecessary intermediate strings.
In the Decode case it just avoids bytes.Map, which is likely slow due
to having to make a function call for each character.
    @kevina
    kevina committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    b8121db View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2016

  1. Use "range" instead of indexes in Decode().

    @kevina
    kevina committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    06d804a View commit details
    Browse the repository at this point in the history

  2. Only allocate a single string/[]byte in DecodeString. 

    Do this by calling the internal decode using the same byte array for
the source and dest.
    @kevina
    kevina committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    f4e78d0 View commit details
    Browse the repository at this point in the history