Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-520] Add apache-commons jar to snowflake dependencies #20

Closed
wants to merge 1 commit into from

Conversation

Kontinuation
Copy link

@Kontinuation Kontinuation commented Mar 24, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Added missing commons-lang3 dependency to snowflake/pom.xml.

How was this patch tested?

Passed the snowflake CI.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@Kontinuation Kontinuation changed the title Add apache-commons jar to snowflake dependencies [SEDONA-520] Add apache-commons jar to snowflake dependencies Mar 24, 2024
@Kontinuation Kontinuation marked this pull request as ready for review March 24, 2024 13:15
@Kontinuation
Copy link
Author

Kontinuation commented Mar 24, 2024

There is a separate PR for updating the snowflake CI https://github.com/wherobots/sedona-snowflake-tester/pull/21/files. That needs to be merged.

@Kontinuation
Copy link
Author

@jiayuasu Is there any repository-level settings for SNOWFLAKE_GEOTOOLS_VERSION environment variable? I've changed the environment variable in snowflake-tester.yml but the workflow job is still using the old version.

@jiayuasu
Copy link
Member

@Kontinuation No, this repo does not have any repo level setting for geotools version. See
image

The organization also has no org level variables at all

@jiayuasu
Copy link
Member

BTW, 2 concurrent Snowflake PR will conflict with each other since they both use the same database and stages

@jiayuasu
Copy link
Member

I have confirmed that now the snowflake tester is picking up 1.5.1-28.2

@Kontinuation
Copy link
Author

I've re-run the CI and it has passed: https://github.com/wherobots/sedona-snowflake-tester/actions/runs/8410338354/job/23028649572?pr=20. The fix seems to be valid.

@jiayuasu jiayuasu closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants