Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: the user interface should be a cancelable promise #14

Open
aaroncox opened this issue Mar 10, 2023 · 1 comment
Open

Refactor: the user interface should be a cancelable promise #14

aaroncox opened this issue Mar 10, 2023 · 1 comment
Assignees
Milestone

Comments

@aaroncox
Copy link
Member

Right now the only cancelable promise we have is the prompt elements, which means that if the modal is closed, only the prompt elements be canceled.

uncancelable

This kind of illustrates the problem.

  • I trigger a signing request
  • Instead of completing the request, I close the modal in the web-ui-renderer.
  • The promise waiting for it doesn’t cancel, it still is processing, which is why when you see me close the WAX window, all the sudden the error pops up.

The entire web ui renderer would have to be refactored into a cancelable promise to resolve this without a prompt. That’s the right solution I think, but is going to be a significant rewrite to pull off, which I don’t want to have to do at this very moment due to the design work going on.

Internal thread: https://greymass.slack.com/archives/C045MUS6F0F/p1678473763146879

@aaroncox
Copy link
Member Author

The workaround right now is to use the prompt element during these "waiting" phases, since that is cancelable. The autocorrect plugin is currently doing this, and the Anchor plugin is doing something similar with a countdown.

@aaroncox aaroncox self-assigned this Apr 11, 2023
@aaroncox aaroncox added this to the Unscheduled milestone Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

1 participant