Add initial version of the WASM-based process executor #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lthibault @aratz-lasa I would love your input and any feedback on capability usage or things I should change to keep it consistent with the rest of the repository :) |
lthibault
requested changes
Mar 2, 2023
There was a problem hiding this comment.
Looking very good 😃
I've flagged a couple of issues that can be resolved straightforwardly (see inline). I also see some opportunities to clean up the lifecycle/refcount management with some advanced capnp features, but I need to stare at this a bit longer.
I'll follow up with another round of commends ASAP.
Great work 👍
lthibault
requested changes
Mar 2, 2023
lthibault
requested changes
Mar 2, 2023
* Pull wazero.Runtime config out of pkg/process; populate via Fx. * Wrap public client capabilities with high-level API types. * Use capnp refcounting to factor out tracking of release funcs.
Refactor feature/proc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used to Github so I created a new pull request instead of using the existing #87 if that's even possible...