Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed25519 identity for libp2p host, instead of RSA + bechmarks for pubsub #44

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

aratz-lasa
Copy link
Contributor

This PR improves the performance of the pubsub system, replacing RSA signing with Ed25519 signing #43 . Benchmarks have been included to compare the different signings, including no signing at all.

Copy link
Collaborator

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging now.

@lthibault lthibault merged commit 612f4ee into master Jul 22, 2022
@lthibault lthibault deleted the feature/pubsub-perf branch July 22, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants