Move process implementation to csp package #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the process implementation from
pkg/processtopkg/csp, along side the channel implementation. There are no functional changes.@mikelsr The rationale is that Wetware logically bundles processes and channels together in the "communicating sequential processe" (CSP) model of concurrency-control. The API assumes that processes and channels go together in the same way that Go associates goroutines and channels, so it makes sense that they would live in the same package. Plus,
csp.Procandcsp.Chanis nice and terse 😄This will simplify the package structure when we start to add the low-level imports & exports needed for our cluster syscall API.