Merge pull request #17 from wetware/bugfix/nonblocking-sub-handler

Fix rpc.Conn disconnect when subscription buffer is full
wetware · Apr 22, 2022 · ff2b530 · ff2b530
2 parents 60f4561 + 8fa954a
commit ff2b530
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/pkg/cap/cluster/anchor_test.go b/pkg/cap/cluster/anchor_test.go
@@ -12,6 +12,9 @@ import (
 
 func TestAnchor(t *testing.T) {
 	t.Parallel()
+	t.Helper()
+
+	t.Skip("TODO:  finish implementing anchor refcounting")
 
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()

diff --git a/pkg/cap/pubsub/client.go b/pkg/cap/pubsub/client.go
@@ -92,17 +92,16 @@ func (h handler) Shutdown() {
 	h.release()
 }
 
-func (h handler) Handle(ctx context.Context, call api.Topic_Handler_handle) error {
+func (h handler) Handle(_ context.Context, call api.Topic_Handler_handle) error {
 	b, err := call.Args().Msg()
 	if err != nil {
 		return err
 	}
 
 	select {
 	case h.ms <- b:
-		return nil
-
-	case <-ctx.Done():
-		return ctx.Err()
+	default:
 	}
+
+	return nil
 }