Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing to minitest #6

Open
coderhs opened this issue Oct 29, 2017 · 2 comments
Open

Move testing to minitest #6

coderhs opened this issue Oct 29, 2017 · 2 comments

Comments

@coderhs
Copy link
Contributor

coderhs commented Oct 29, 2017

I feel the spec library of crystal is really limiting. As for example I am declaring the array variable on each case, instead of having a before_each. Guess I can blame my testing background for rspec and minitest for that 😬

I suggestion https://github.com/ysbaddaden/minitest.cr as it has the features like let or we can use spec2 (https://github.com/waterlink/spec2.cr) which has stuff like random order, before for current and nested context.

@werner
Copy link
Owner

werner commented Nov 7, 2017

spec2 doesn't look like to be maintained, I could consider migrating to minitest, but it seems to require some work.

@coderhs
Copy link
Contributor Author

coderhs commented Nov 7, 2017

I can start work on it on another branch. Should be easy to implement or we can have both in the same project for now and then phase our spec, since minitest will be a development dependency I believe it won't be added when someone uses this shard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants