-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Jest 19 #71
Conversation
@ev1stensberg could you please look into the failing tests? Something with mocks I guess. |
Sure. Mind waiting 1:30h? I'm doing Google Hashcode right now |
My guess is that you removed the rootpath, so it can't find relative paths to the mock folder |
No, it was failing with the config in place. It's not needed in this form BTW since these are defaults. |
checking them out now, giveme some mins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm mergeit ✅
I'll rebase and merge. |
14d8a26
to
b3be2c8
Compare
* fix: Upgraded to Jest 19 * Removed unnecessary Jest config * fix: temporary use absolute paths for mock requires * build: Generate coverage report
What kind of change does this PR introduce?
build related change
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A