Upgrade to Jest 19 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ev1stensberg could you please look into the failing tests? Something with mocks I guess. |
|
Sure. Mind waiting 1:30h? I'm doing Google Hashcode right now |
|
My guess is that you removed the rootpath, so it can't find relative paths to the mock folder |
|
No, it was failing with the config in place. It's not needed in this form BTW since these are defaults. |
|
checking them out now, giveme some mins |
|
I'll rebase and merge. |
okonet
force-pushed
the
fix/update-jest
branch
from
14d8a26
to
b3be2c8
Compare
evenstensberg
pushed a commit
that referenced
this pull request
Mar 4, 2017
* fix: Upgraded to Jest 19 * Removed unnecessary Jest config * fix: temporary use absolute paths for mock requires * build: Generate coverage report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
build related change
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A