-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove v8-compile-cache #3006
Conversation
@@ -246,7 +246,6 @@ class WebpackCLI { | |||
} catch (error) { | |||
let previousModuleCompile; | |||
|
|||
// TODO Workaround https://github.com/zertosh/v8-compile-cache/issues/30 | |||
if (this._originalModuleCompile) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me also remove this workaround logic
Codecov Report
@@ Coverage Diff @@
## master #3006 +/- ##
==========================================
- Coverage 94.89% 94.86% -0.04%
==========================================
Files 22 22
Lines 1625 1615 -10
Branches 482 480 -2
==========================================
- Hits 1542 1532 -10
Misses 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
NA
Summary
Removes v8-compile-cache package which creates problems while using with ESM
Does this PR introduce a breaking change?
no, initiation time will be slightly more
Other information
Fix #3005