-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle undefined configuration export #2930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2930 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 31 31
Lines 1684 1684
Branches 481 483 +2
=======================================
Hits 1602 1602
Misses 82 82
Continue to review full report at Codecov.
|
@webpack/cli-team need approvals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments.
What kind of change does this PR introduce?
fix and test
Did you add tests for your changes?
Yup, did in TDD fashion.
If relevant, did you update the documentation?
Not required.
Summary
Treat
undefined
configuration as a case forzero-config
Does this PR introduce a breaking change?
Nope.
Other information
/cc @alexander-akait