-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to run commands not requiring webpack without webpack installation #2907
feat: allow to run commands not requiring webpack without webpack installation #2907
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2907 +/- ##
==========================================
+ Coverage 94.85% 95.11% +0.25%
==========================================
Files 31 31
Lines 1673 1679 +6
Branches 468 480 +12
==========================================
+ Hits 1587 1597 +10
+ Misses 86 82 -4
Continue to review full report at Codecov.
|
2186874
to
41868ba
Compare
@@ -1,27 +1,27 @@ | |||
import { devServerOptionsType } from "./types"; | |||
|
|||
const WEBPACK_PACKAGE = process.env.WEBPACK_PACKAGE || "webpack"; | |||
const WEBPACK_DEV_SERVER_PACKAGE = process.env.WEBPACK_DEV_SERVER_PACKAGE || "webpack-dev-server"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snitin315 We should document WEBPACK_DEV_SERVER_PACKAGE
after merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take care of it 👍🏻
Any plans on releasing this change in the near future? |
Yes, in near future, need to fix the one problem on webpack side |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes, some tests
If relevant, did you update the documentation?
No need
Summary
Allow to run
npx webpack-cli info
withoutwebpack
installationDoes this PR introduce a breaking change?
No
Other information
due
v8-compile-cache
has bug withimport()
, after this refactor webpack can useimport()
to load ECMA modules, it is great fix