-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show possible values for option in help output #2819
Conversation
(flag) => option.long === `--${flag.name}`, | ||
); | ||
|
||
if (flag && flag.configs[0].values) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have more them, i.e. config[1]
/config[2]
, I think better use map
here and collect them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, one note
Codecov Report
@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 93.96% 94.05% +0.08%
==========================================
Files 32 32
Lines 1706 1715 +9
Branches 492 495 +3
==========================================
+ Hits 1603 1613 +10
+ Misses 103 102 -1
Continue to review full report at Codecov.
|
Feel free to merge |
Need one more review. /cc @webpack/cli-team |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes updated snaps
If relevant, did you update the documentation?
No
Summary
show possible values for option in help output
Does this PR introduce a breaking change?
No
Other information
No