-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show default value in help output if available #2814
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2814 +/- ##
==========================================
+ Coverage 93.99% 94.11% +0.11%
==========================================
Files 32 32
Lines 1715 1715
Branches 495 495
==========================================
+ Hits 1612 1614 +2
+ Misses 103 101 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there tests for this?
None at present. I will see if I can add one. |
@snitin315 yep, let's add test, we can do it in |
@snitin315 friendly ping |
fed29b0
to
d303b5a
Compare
d303b5a
to
2c60e03
Compare
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Manual testing
If relevant, did you update the documentation?
Summary
show default value in help output if provided in the
option
object.Does this PR introduce a breaking change?
None
Other information
No